ka-extension / ka-extension-ts

A browser extension for Khan Academy.
MIT License
19 stars 11 forks source link

Fix share button #149

Closed MatthiasPortzel closed 5 years ago

MatthiasPortzel commented 5 years ago

Fixes #146.

133:

Remove the empty text nodes in between some of the program buttons, as they were making the spaces inconsistent.

This method was causing issues with the Share button, for reasons I don't fully understand. This PR fixes those issues by changing button respacing to be done primarily in CSS. We add text nodes to buttons that didn't have one instead of removing text nodes.

This also changes how the CSS for the report buttons is handled.

This also switches to use body instead of #page-container in CSS. This is needed to make sure our CSS takes precedence over KA's, and both #page-container and body have that effect. We should be consistent, however. Ethan had used body prior to me using #page-container, and it's shorter, so this switches everything to body.