search

ka-extension / ka-extension-ts

A browser extension for Khan Academy.
MIT License
19 stars 11 forks source link

WIP working on fixing notifs #257

Closed MatthiasPortzel closed 1 year ago

EthanLuisMcDonough commented 1 year ago

Any updates on this? I can help work on it if you're busy.

MatthiasPortzel commented 1 year ago

I'm leaning towards just merging it as is, since I don't know when I would circle back around to it.

graphQL is a blessing and a curse since the graphQL endpoint response lists all possible properties that can exist on the notification object. So in this PR I converted that information into TypeScript types (poorly). IIRC I got basic notifications (like program comments) working, but there are a bunch of other notification types.

If you want to work on it, that would be great.

EthanLuisMcDonough commented 1 year ago

Made a couple changes. I don't have very many different types of notifications in my inbox, but it seems to be working with the ones I have. I think we should probably aim to release what we have after this merges.

EthanLuisMcDonough commented 1 year ago

@MatthiasPortzel Are you OK if I merge this? GH won't let me add you as a reviewer because this is your PR.

MatthiasPortzel commented 1 year ago

Yep, it looks good.