search

ka9q / ka9q-radio

Multichannel SDR based on fast convolution and IP multicasting
GNU General Public License v3.0
161 stars 36 forks source link

Include missed on attr.c #1

Closed ghost closed 2 years ago

ghost commented 2 years ago

In attr.c it has:

#ifdef __linux__
#include <attr/xattr.h>
#else
#include <sys/xattr.h>
#endif

But on Ubuntu the include is in the sys directory. Changed to:

#include <sys/xattr.h>

Maybe other linux versions differ, which will complicate the #ifdef

ka9q commented 2 years ago

That's weird. The man page now says

include <sys/types.h>

include <sys/xattr.h>

Maybe it changed after I originally wrote attr.c. I hate this sort of thing. Anyway, I've made the change. Thanks for the report! --Phil

On 4/14/22 10:47, srsampson wrote:

In attr.c it has:

|#ifdef linux #include <attr/xattr.h> #else #include <sys/xattr.h>

endif |

But on Ubuntu the include is in the |sys| directory. Changed to:

|#include <sys/xattr.h> |

Maybe other linux versions differ, which will complicate the #ifdef

— Reply to this email directly, view it on GitHub https://github.com/ka9q/ka9q-radio/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJDI443YOIRF7MWALBEZPTVFBK3PANCNFSM5TOOMRJQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ka9q commented 2 years ago

well, that wasn't very hard...

On 4/15/22 10:11, srsampson wrote:

Closed #1 https://github.com/ka9q/ka9q-radio/issues/1.

— Reply to this email directly, view it on GitHub https://github.com/ka9q/ka9q-radio/issues/1#event-6441351954, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJDI4374AAKN4R4P4IVMC3VFGPLTANCNFSM5TOOMRJQ. You are receiving this because you commented.Message ID: @.***>

ghost commented 2 years ago

well, that wasn't very hard...

I'm just glad I wasn't some special case! Thanks.