search

kaaholst / android-squeezer

Remote control for your Logitech Media Server ("Squeezeserver" etc) and players.
Apache License 2.0
75 stars 15 forks source link

Fix settings and translations #741

Closed viertelb closed 2 years ago

viertelb commented 2 years ago

The settings page is not very consistent at the moment. For example the sub menu name "squeezer-interface" makes no sense. I tried to make it better and deleted some translations in the process.

We should maybe have a new sub menu called "long press items" with shortcuts and archive and rename the old "interface" to "others" (or similar) and just have theme and playlist in it.

kaaholst commented 2 years ago

This branch cannot be rebased due to conflicts. Because it had two commits Fix for Random Play with several players and the merge which was already on develop. So I cherry picked Fix settings descriptions, options and strings instead, so this can be closed.

Regarding "Long press items" it should refer to the functionality rather than how it's performed. Maybe something like "Home Menu Customization". "Others" could be "Appearance", and the playlist could be moved out of that section. All this can come later, as it may change depending on which settings items we will have.

kaaholst commented 2 years ago

This is cherry picked, so closing this

viertelb commented 2 years ago

Regarding "Long press items" it should refer to the functionality rather than how it's performed. Maybe something like "Home Menu Customization".

From a logical point of view, of course. On the other hand, home menu customization sounds abstract to the user. Maybe she does not even know what the home menu is (I did not). Everybody knows what a "long press" is. Also, this way people will be able to recognise that the function of "long press" exists and that it can have several different effects.