search

kaaholst / android-squeezer

Remote control for your Logitech Media Server ("Squeezeserver" etc) and players.
Apache License 2.0
75 stars 15 forks source link

Lock menu & sync menu #827

Open NohWayJose opened 2 weeks ago

NohWayJose commented 2 weeks ago

Sorry, I'm being lazy and putting two related feature requests in one issue.

  1. In Player's drop down menu please add a toggle to lock the menu, so long press will no longer move an item to or from the Archive folder
  2. In settings, add a check box to make the menus for all the players the same, based on selection from a drop down to choose which player to use as the template. Also, check box for lock menus, so further edits are blocked. If lock is off but menu sync is on, edits to one becomes edits to all. If lock is on and sync is on, no changes are permitted. Turning sync off (grey out the dropdown) means subsequent edits are only applied to the currently selected player
kaaholst commented 2 weeks ago

If I understand correct, something similar is already possible. In settings for archive and shortcuts, you can select to deactivate long press, but current archive/shortcuts. This will effectively lock your selections, i.e. prevent from accidentally long pressing an item.

Before locking, you will have to set up your menu, for each player. Since some items are only available to some players, these settings have to be per player. We get the items from the server, which will return different items depending on the player.

NohWayJose commented 1 week ago

Thanks @kaaholst I found that setting but (speaking as a UX designer) it's a bit confusing. I disabled but kept the archive. I could still long press some menu items and they'd be removed. Some couldn't but it's not clear why.

Putting the request 2 (synchronizing menus) to one side, I think what you propose is only a partial answer. A simple 'lock menus' in the top level ... menu, reliably locking all elements in the menu, would be much more usable.

kaaholst commented 5 days ago

I'm not able to reproduce your issue, are you sure you deactivated both archive and shortcuts? You find those 2 settings in the “Shortcuts etc.” section as “Archive” and “Shortcuts” respectively.

I think that the relation between a “lock menus” setting and the Archive and Shortcut settings would be confusing. I'd prefer to fix the confusion arising from those two settings if possible, rather than introducing a new setting. This could e.g. be by changing the wording from “Disabled, but …” to something involving the word locked. I'm also open to combining those two settings into one, if you have any suggestion which would make this understandable.

Actually, I think the basic confusion stems from understanding what can be archived, and what can be a shortcut. E.g. items in My Music can be archived, but items in My Apps can be a shortcut. It is decided by the server, and documented here Home Menu Items versus SlimbrowseItems.

Finally, could you elaborate what “Player's drop-down menu” is, and which menu would be locked by “a toggle to lock the menu” (LMS refers to all pages as menus).