Add `pre-commit` - Githubissues

kaanaksit / odak

Scientific computing library for optics, computer graphics and visual perception.

https://kaanaksit.com/odak

Mozilla Public License 2.0

177 stars 52 forks source link

Add `pre-commit` #38

Closed SauravMaheshkar closed 2 years ago

SauravMaheshkar commented 2 years ago

This PR aims to solve #36. I've only added flake8 and autopep8 for now, with a couple of other miscellaneous hooks. odak follows a large set of configurations for flake8 and it doesn't make sense IMO to add them as args in the pre-commit config. A setup.cfg or a .flake8 configuration file makes more sense.

Looking forward to hear feedback.

SauravMaheshkar commented 2 years ago

Request for Review @kunguz

kaanaksit commented 2 years ago

We have an intention to have a smaller set of dependencies in our requirements.txt in the future. Therefore, I am afraid I can not increase the size of our requirements.txt with pre-commit. I will close the pull request.