search

kaanaksit / odak

Scientific computing library for optics, computer graphics and visual perception
https://kaanaksit.com/odak
Mozilla Public License 2.0
171 stars 48 forks source link

Gerchberg Saxton bug #40

Closed jsreddy closed 2 years ago

jsreddy commented 2 years ago

https://github.com/kunguz/odak/blob/c8af57e0ed6fcda579762eeeec43e071384921f6/odak/learn/wave/classical.py#L290

I believe there is a bug in the GS pytorch version Shouldn't the amplitude be set from reconstruction rather than hologram?

kaanaksit commented 2 years ago

You are right. Please have a pull request so thatwe can incorporate it in the next version. Thanks!

kaanaksit commented 2 years ago

9df3b6a3cc9a4c005586a133161be55e85b94a80 resolves the issue. Please do not hesitate to reopen the issue if the problem persists. Please make sure to use odak from the repository but not from pip as this change will not be reflected in pip until we release odak 0.2.0. Thanks!

kaanaksit commented 2 years ago

odak is now at 0.2.0