kaanaksit / odak

Scientific computing library for optics, computer graphics and visual perception.
https://kaanaksit.com/odak
Mozilla Public License 2.0
176 stars 52 forks source link

vectorize the function that check triangle intersection #93

Closed yaio4109 closed 9 months ago

yaio4109 commented 9 months ago

When i use latest version of odak code, the function checking triangle intersection can only check one triangle at a time. So if i try to check a lot of triangle intersections, i need to loop through the triangles, which is slow in Python. Therefore, I rewrote the code associating with triangle intersection in vectorization form.

kaanaksit commented 9 months ago

Thank you, @yaio4109, for improving odak. Please note that once we have your updates, it will appear in the next stable version, which is 0.2.6. Could you please verify and help me to improve following so that I can merge your updates with the origin/master:

yaio4109 commented 9 months ago

I add my name Wu Jialun to the THANKS.txt and CITATION.cff, and add the unit test for intersect_w_triangle_batch. When i write the unit test, i found that the function intersect_w_surface should check the shape of points not the length of points.

If having other issue, please let me know. 🤗

kaanaksit commented 9 months ago

Thank you very much, @yaio4109, for your contributions to odak. I have reviewed and merged your edits. They should now be available in the repository. Your functions will become available to other users installing odak using pip in the next version, 0.2.6.

I hope to be able to meet in-person one day, and please to meet you virtually!