search

kaandedeoglu / KDCircularProgress

A circular progress view with gradients written in Swift
MIT License
1.21k stars 217 forks source link

Completion status returning false on complete #23

Closed ghost closed 8 years ago

ghost commented 8 years ago

I create a CircularProgress at on button press. I than send off a GET request and if I am animating when I finish with my request I pause and set a new animateFromAngle to complete in 1 second. I appears that doing this is causing the completed to return false in the new animeFromAngle.

dfusilier commented 8 years ago

Also having this problem.

kaandedeoglu commented 8 years ago

This should be solved with the latest version of the library. Can you please try and confirm?

kaandedeoglu commented 8 years ago

Closing this due to the inactivity. Feel free to reopen if the problem persists.

ghost commented 8 years ago

Sorry, I have been busy working on another project. It appears to still occur. I've also noticed that if i call animate(toAngle) while another animation is occurring that is returning false for completed.

kaandedeoglu commented 8 years ago

@LJBowen This is the intended behavior. The completed argument is true only if the animation ends on its own. You can use it to implement your completion logic. Please also see #47

ghost commented 8 years ago

@kaandedeoglu Thanks!