Bundle support for framework

kaandedeoglu / Shark

Swift CLI for strong-typing images, colors, storyboards, fonts and localizations

MIT License

381 stars 15 forks source link

Bundle support for framework #16

Closed quangDecember closed 4 years ago

quangDecember commented 4 years ago

without setting bundle for the generated code, it will crash when using with framework bundles. I've just completed support for UIImage. If you agree on my solution, I'll continue with the other NSLocalizedString, UIColor,...

kaandedeoglu commented 4 years ago

Looking good, please add support for UIImage and UIColor and then we can merge 🚀

quangDecember commented 4 years ago

Hey I added support for NSLocalizedString and UIColor already, tho I'm not sure why there're two places for NSLocalizedString(

quangDecember commented 4 years ago

Yup, I tested on my projects, useful to me, because I mainly work on frameworks. On NSLocalizedString I only tested on .string files, but I think it would be the same for others

kaandedeoglu commented 4 years ago

Merged, thank you! I've also updated the homebrew formula so you can update to the new version (1.1.3) using brew update + brew upgrade