search

kaandedeoglu / Shark

Swift CLI for strong-typing images, colors, storyboards, fonts and localizations
MIT License
381 stars 15 forks source link

Not working with LaunchImage on xcassets #4

Closed filipealva closed 8 years ago

filipealva commented 8 years ago

Hey,

It does not works when the project has a LaunchImage. It creates the following code for LaunchImage:

public enum LaunchImage.launchimage {
}

which causes a build time crash.

kaandedeoglu commented 8 years ago

@filipealva Hey there, thanks for spotting that, looks like a very serious mistake on my part!

I'll fix it today and push a fix

Just to be on the same page, Shark will ignore all LaunchImage imagesets (as it does for AppIcon imagesets) - is that okay for you?

filipealva commented 8 years ago

@kaandedeoglu Nice! Yes, its ok to ignore all LaunchImage on assets.

Congrats about the project, and thank you for the fast feedback :+1:

kaandedeoglu commented 8 years ago

@filipealva I just released version 0.1.1 and it's ready to use through Cocoapods or manually.

I'm leaving this open until you confirm that everything works as expected. Please let me know when you try - again, thanks for reaching out :+1:

filipealva commented 8 years ago

@kaandedeoglu I tried right now, it is working properly!

Thanks :)