search

kaanginam / expandable-notifications

Makes notifications in notification list expandable
GNU Affero General Public License v3.0
25 stars 2 forks source link

Expandable notifications not working #1

Open snake3lake opened 2 years ago

snake3lake commented 2 years ago

Doesn't seem to work at all? Installed by moving the extension to ~/.local/share/gnome-shell/extensions: $ ls -l expandable-notifications@kaan.g.inam.org/ total 28 -rw-rw-r-- 1 marcel marcel 14848 apr 11 19:52 extension.js -rw-rw-r-- 1 marcel marcel 871 apr 11 19:52 metadata.json drwxrwxr-x 2 marcel marcel 4096 apr 11 19:52 schemas

$ gsettings --schemadir ~/.local/share/gnome-shell/extensions/expandable-notifications@kaan.g.inam.org/schemas/ get org.gnome.shell.extensions.expandable-notifications-settings expand-mode 'ARROW'

$ dpkg -l gnome-shell Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-==============-=============-============-===================================== ii gnome-shell 40.5-1ubuntu2 amd64 graphical shell for the GNOME desktop

$ lsb_release -a LSB Version: core-11.1.0ubuntu3-noarch:printing-11.1.0ubuntu3-noarch:security-11.1.0ubuntu3-noarch Distributor ID: Ubuntu Description: Ubuntu 21.10 Release: 21.10 Codename: impish

Nothing seems to be changing in the notifications: image

snake3lake commented 2 years ago

Hold on! Let me double check. I now see a little arrow behind the notification.

komipon commented 2 years ago

Hi! Can you update me on if it worked or not?

snake3lake commented 2 years ago

I can expand the notification using the arrow alright although it only shows the first 2 lines of the notification after clicking the arrow. I used the following text to test: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."

kaanginam commented 2 years ago

That is indeed odd. Can you tell me how you spawn the notification, so I can reproduce the issue?

snake3lake commented 2 years ago

The notifications come from Microsoft Teams installed as snap. I wasn't able to reproduce the issue any other way (notify-send p.e. in which case an arrow is not even shown).

snake3lake commented 1 year ago

The notifications come from Microsoft Teams installed as snap. I wasn't able to reproduce the issue any other way (notify-send p.e. in which case an arrow is not even shown).

Op vr 15 apr. 2022 17:01 schreef kaanginam @.***>:

That is indeed odd. Can you tell me how you spawn the notification, so I can reproduce the issue?

— Reply to this email directly, view it on GitHub https://github.com/kaanginam/expandable-notifications/issues/1#issuecomment-1100160772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPMKWLO72GGJYZV7BGU7KDVFGAFFANCNFSM5TFNXLCA . You are receiving this because you authored the thread.Message ID: @.***>

kaanginam commented 1 year ago

The notifications come from Microsoft Teams installed as snap. I wasn't able to reproduce the issue any other way (notify-send p.e. in which case an arrow is not even shown).

Hmm, okay, I will check it out. About your second part, how exactly did you use notify-send?

snake3lake commented 1 year ago

Like this: $ notify-send "this is a very long long long text this is a very long long long text this is a very long long long text"

ZimbiX commented 1 year ago

It's working fine for me! However, the expansion only applies to a long notification body, not the notification summary. Which is probably enough for me (not using Teams). Thanks for the extension!

➜ notify-send --help                                                                                                    
Usage:
  notify-send.sh [OPTION...] <SUMMARY> [BODY] - create a notification
[...]

➜ notify-send "summary" "body: a short one"                                                                                             

➜ notify-send "summary" "body: this is a very long long long text this is a very long long long text this is a very long long long text"

➜ notify-send "summary: a long one - kjhsd fkjhds lkfjhdsfkljs hdflkj hdsflkj hdslkfj hdslkfj hsdlkfj hdsf" "body: short"

Screenshot from 2023-01-19 21-48-03

Screenshot from 2023-01-19 21-48-13

➜ gnome-shell --version
GNOME Shell 43.2
kaanginam commented 1 year ago

It's working fine for me! However, the expansion only applies to a long notification body, not the notification summary. Which is probably enough for me (not using Teams). Thanks for the extension!

➜ notify-send --help                                                                                                    
Usage:
  notify-send.sh [OPTION...] <SUMMARY> [BODY] - create a notification
[...]

➜ notify-send "summary" "body: a short one"                                                                                             

➜ notify-send "summary" "body: this is a very long long long text this is a very long long long text this is a very long long long text"

➜ notify-send "summary: a long one - kjhsd fkjhds lkfjhdsfkljs hdflkj hdsflkj hdslkfj hdslkfj hsdlkfj hdsf" "body: short"

Screenshot from 2023-01-19 21-48-03

Screenshot from 2023-01-19 21-48-13

➜ gnome-shell --version
GNOME Shell 43.2

ah yeah exactly, thanks for pointing this out! I think this is where the confusion came from! If this is a wanted feature (expanding on summary being too long), I will look into this. I have been wanting to work on this again for a while now anyway.

Thanks again @ZimbiX !

snake3lake commented 1 year ago

Ah under Ubuntu 22.10 the notifications have been moved to the Quick Settings area and it's now not working at all. Can't send you an image: Quick Settings closes as soon as Screenshot is started. It might be an idea to be able to adjust the size of summary and body in the settings.

Op ma 17 apr 2023 om 14:02 schreef kaanginam @.***>:

It's working fine for me! However, the expansion only applies to a long notification body, not the notification summary. Which is probably enough for me (not using Teams). Thanks for the extension!

➜ notify-send --help Usage: notify-send.sh [OPTION...]

[BODY] - create a notification [...]

➜ notify-send "summary" "body: a short one"

➜ notify-send "summary" "body: this is a very long long long text this is a very long long long text this is a very long long long text"

➜ notify-send "summary: a long one - kjhsd fkjhds lkfjhdsfkljs hdflkj hdsflkj hdslkfj hdslkfj hsdlkfj hdsf" "body: short"

[image: Screenshot from 2023-01-19 21-48-03] https://user-images.githubusercontent.com/2916331/213423227-c95066de-1700-4933-a16c-d7ceccddd6b4.png

[image: Screenshot from 2023-01-19 21-48-13] https://user-images.githubusercontent.com/2916331/213423223-28979f1c-a686-4518-857a-c60b8f7aabfe.png

➜ gnome-shell --version GNOME Shell 43.2

ah yeah exactly, thanks for pointing this out! I think this is where the confusion came from! If this is a wanted feature (expanding on summary being too long), I will look into this. I have been wanting to work on this again for a while now anyway.

Thanks again @ZimbiX https://github.com/ZimbiX !

— Reply to this email directly, view it on GitHub https://github.com/kaanginam/expandable-notifications/issues/1#issuecomment-1511211007, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPMKWMSJGQ2AXXNLFAPZADXBUWOTANCNFSM5TFNXLCA . You are receiving this because you authored the thread.Message ID: @.***>

snake3lake commented 1 year ago

In Ubuntu 23.04 notifications are back where they were, however Expandable notifications is not supported anymore: $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 23.04 Release: 23.04 Codename: lunar

$ dpkg -l gnome-shell
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-==============-=============-============-===================================== ii gnome-shell 44.0-2ubuntu3 amd64 graphical shell for the GNOME desktop

Hyperspeed1313 commented 10 months ago

Virtualbox guest utilities is sending me a notification (an error I don't know how to resolve) that's very long and all in the title field. I was really hoping this extension would let me see what's actually gone wrong.