kaanginam / expandable-notifications

Makes notifications in notification list expandable
GNU Affero General Public License v3.0
26 stars 2 forks source link

Shadows on notifications #10

Closed somepaulo closed 1 year ago

somepaulo commented 1 year ago

This extension adds shadows to notifications in the Notification Center. Disabling it removes the shadows. You can run notify-send -t 3000 -i face-smile "The First Notification" "Hello <b>World</b>" to generate a test notification.

Screenshot from 2023-05-16 17-10-54

kaanginam commented 1 year ago

Hey, if this is something that needs to be removed I'll look at it.

The extension doesn't add the shadows but it changes the class of the Notification to be that of the extension you see on the screen.

If that has shadows, that's probably why the extension is displaying them.

Thanks for the issue!

somepaulo commented 1 year ago

I think this is due to what's described on lines 144-146 of the extension – using the NotificationBanner class instead of the NotificationMessage one. Since banners do have shadows, they must come from that class.

It's easy to fix by adding a custom class to the banner with message.add_style_class_name('expandable');, and a stylesheet.css file with .expandable{.box-shadow: none !important;}.

somepaulo commented 1 year ago

I fixed this in #11

kaanginam commented 1 year ago

I think this is due to what's described on lines 144-146 of the extension – using the NotificationBanner class instead of the NotificationMessage one. Since banners do have shadows, they must come from that class.

It's easy to fix by adding a custom class to the banner with message.add_style_class_name('expandable');, and a stylesheet.css file with .expandable{.box-shadow: none !important;}.

That is what I was trying to say, just did not have the time for the specifics - thanks for the PR! It is now merged and waiting for review on the extensions page.