Add Gnome 45 Support - Githubissues

muhammad-ans commented 10 months ago

There are changes in gnome 45 that breaks every extension. https://gjs.guide/extensions/upgrading/gnome-shell-45.html

galen1423 commented 9 months ago

+1 for support Gnome 45

Thanks for your work

okarika commented 9 months ago

+1 for Gnome 45

kaanginam commented 9 months ago

quickly wokred on a gnome 45 version! As soon as it passes review, would be great if you guys can come back to me and confirm it works fine @galen1423 @okarika @muhammad-ans :D

muhammad-ans commented 9 months ago

Working as expected. Thanks.

Lythenas commented 8 months ago

I updated to the latest version on extensions.gnome.org and I'm getting this error on Gnome 45:

JS ERROR: Extension expandable-notifications@kaan.g.inam.org: ReferenceError: NotificationSection is not defined
                                           disable@file:///home/ms/.local/share/gnome-shell/extensions/expandable-notifications@kaan.g.inam.org/extension.js:436:9
                                           _callExtensionDisable@resource:///org/gnome/shell/ui/extensionSystem.js:201:32
                                           _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:619:24
                                           async*_sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:799:20
                                           ExtensionManager/<@resource:///org/gnome/shell/ui/extensionSystem.js:43:18
                                           _callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
                                           _emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
                                           _sync@resource:///org/gnome/shell/ui/sessionMode.js:212:14
                                           pushMode@resource:///org/gnome/shell/ui/sessionMode.js:170:14
                                           activate@resource:///org/gnome/shell/ui/screenShield.js:621:34
                                           lock@resource:///org/gnome/shell/ui/screenShield.js:688:14
                                           LockAsync@resource:///org/gnome/shell/ui/shellDBus.js:519:28
                                           _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
                                           _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
                                           @resource:///org/gnome/shell/ui/init.js:21:20

I believe I got this error after locking and unlocking.

kaanginam commented 8 months ago

I updated to the latest version on extensions.gnome.org and I'm getting this error on Gnome 45:

JS ERROR: Extension expandable-notifications@kaan.g.inam.org: ReferenceError: NotificationSection is not defined
                                           disable@file:///home/ms/.local/share/gnome-shell/extensions/expandable-notifications@kaan.g.inam.org/extension.js:436:9
                                           _callExtensionDisable@resource:///org/gnome/shell/ui/extensionSystem.js:201:32
                                           _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:619:24
                                           async*_sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:799:20
                                           ExtensionManager/<@resource:///org/gnome/shell/ui/extensionSystem.js:43:18
                                           _callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
                                           _emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
                                           _sync@resource:///org/gnome/shell/ui/sessionMode.js:212:14
                                           pushMode@resource:///org/gnome/shell/ui/sessionMode.js:170:14
                                           activate@resource:///org/gnome/shell/ui/screenShield.js:621:34
                                           lock@resource:///org/gnome/shell/ui/screenShield.js:688:14
                                           LockAsync@resource:///org/gnome/shell/ui/shellDBus.js:519:28
                                           _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
                                           _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
                                           @resource:///org/gnome/shell/ui/init.js:21:20

I believe I got this error after locking and unlocking.

Thanks for letting me know! I know what the issue is and will fix when I have time.

sidevesh commented 8 months ago

I see that the new version fixed the error and things are working fine on Gnome 45 now, this can be closed I think.

Lythenas commented 8 months ago

Ah didn't even see it was updated^^ I can also confirm I don't see the error anymore and it looks like it's working fine.

sidevesh commented 8 months ago

@muhammad-ans @kaanginam Can you close this now that all issues are resolved and things are working okay

kaanginam / expandable-notifications

Add Gnome 45 Support #14