kaangiray26 / forte

Self-hosted, music streaming platform
https://forte.buzl.uk/
GNU General Public License v3.0
341 stars 12 forks source link

Go off embedded tags for albums instead of folder name #89

Closed JaxzKyd closed 1 year ago

JaxzKyd commented 1 year ago

So after starting up forte again with my entire library this time, I noticed a few things... For the record this is how my library is structured

/library/
└── artist name/
   ├── [year] album name (album type)/
   |   ├── 01 - Title.flac
   |   ├── 02 - Title.flac
   |   ...
   |   └── cover.jpg # occasionally there isn't a cover.jpg file and the covers are embedded, but that's a whole different thing
   |

Here is an example from my library

/library/
└── Bea Miller/
   ├── [2018] aurora (Album)/
   |  ├── 01 - song like you.flac
   |  ├── 02 - burning bridges.flac
   |  ├── 03 - motherlove.flac
   |  ├── 04 - i can't breathe.flac
   |  ├── 05 - like that.flac
   |  ├── 06 - buy me diamonds.flac
   |  ├── 07 - outside.flac
   |  ├── 08 - girlfriend.flac
   |  ├── 09 - bored.flac
   |  ├── 10 - warmer.flac
   |  ├── 11 - repercussions.flac
   |  ├── 12 - S.L.U.T..flac
   |  ├── 13 - crash&burn.flac
   |  ├── 14 - to the grave.flac
   |  └── cover.jpg
   ├── [2019] feel something (Single)/
   |  ├── 01 - feel something.flac
   |  └── cover.jpg
   ├── [2020] elated! (Album)/
   |  ├── 01 - hallelujah.flac
   |  ├── 02 - FEEL SOMETHING DIFFERENT.flac
   |  ├── 03 - forever is a lie.flac
   |  ├── 04 - making bad decisions.flac
   |  ├── 05 - i never wanna die.flac
   |  ├── 06 - wisdom teeth.flac
   |  ├── 07 - self crucify.flac
   |  └── cover.jpg
   ├── [2023] lonely bitch (Single)/
   |  ├── 01 - lonely bitch.flac
   |  └── cover.jpg
   |

I think this is a cause of a few issues in my forte instance, here are some login credentials for it Server:https://forte.rimatori.com Username:Kaan Token:a8347f83092f6a0fe726734ee14274ab Now on that server, every album folder follows that above structure EXCEPT a few here in there, most notably, K-12 (After School - Deluxe Edition) Cry Baby (Deluxe Edition) Now these albums are just in a /artist/album name instead of the /artist/[year] album name (album type) like the rest of my library. As you can see for yourself, they are the only albums with album art and playable tracks, the rest of the albums just show up like this image image I don't know, I assume it's because it's building albums based on folder names and not tags?

kaangiray26 commented 1 year ago

Which version is this btw?

JaxzKyd commented 1 year ago

You update really fast haha 😅 I believe I built the images right after you made this commit 8d88b9c

kaangiray26 commented 1 year ago

I can't seem to reproduce the problem myself in my own library. Can you maybe send me one of your problematic album folders as a zip in private so that I can try it in my own machine?

JaxzKyd commented 1 year ago

Not a problem, uploading it to mega now and I'll send you the link in an email

kaangiray26 commented 1 year ago

Great, thanks so much!

JaxzKyd commented 1 year ago

Sent out the email 👍

kaangiray26 commented 1 year ago

This commit should solve the problem for good.

It was a mistake I've made using the glob library and function.

JaxzKyd commented 1 year ago

We're back in business 🎉