search

kaansoral / adventureland

Adventure Land The Open Source CODE MMORPG
Other
189 stars 60 forks source link

hotfix for magiport #110

Closed thmsndk closed 6 months ago

thmsndk commented 6 months ago

give magiport a large range, we should handle .global skills and ignore the range check if they are global

FreezePhoenix commented 6 months ago

Isn't magiport intentionally cross-map? I don't see what adding a range value contributes.

thmsndk commented 6 months ago

@FreezePhoenix It is, but the isTargetTooFar check currently defaults to player range, without respecting .global This was an easy hotfix to do to make it work again, a proper PR to handle .global should be made :)

As a result players using magiport currently receives this error image

FreezePhoenix commented 6 months ago

@earthiverse You broke magiport. @kaansoral A fix for this should be made before servers are restarted.

FreezePhoenix commented 6 months ago

This PR is rendered inconsequential by 1e43904aee95c907f5bc0aca6e5c388cb4f80965

thmsndk commented 6 months ago

Yeah, I was too afraid to mess anymore with the logic in socket.on("skill" when I don't have the ability to test it and get the full understanding of it :)

Closing this PR :)