Open thmsndk opened 8 months ago
I currently can't think of other things I want to add to this PR, reviews will be much appreciated. I have tested it on my local dev server, and everything works as expected as far as I can tell.
@thmsndk Since this PR is big and I've left several comments, I'll let you tell me when you consider it ready for me to take another look at it.
Please write a small word after each of my open conversations to let me know how you've addressed it so I can better keep track.
I'm unsure if my latest commit will break the live production servers as I've been messing around with how "https_mode" is utilized https://github.com/kaansoral/adventureland/pull/116/commits/8c20b823f373de25948b7c0ccc611ac95d90cafd
More research and testing is needed, but server_eval
is now fixed on my local docker environment.
The following PR aims to move more configurations out into configuration files that are not comitted to git, this way you have more control on the specific server installation.
api/characters_and_servers
would return a hardcoded192.168.1.125
ip when running in SDK modegame_name
,appengine_id
,live_domain
,sdk_domain
IP_TO_SUBDOMAIN
has also been moved here.environment.py
variables.js
template.variables.js
server.js mode
drm_check
that causes the authfail debuffnotverified_debuff
closes #94
secrets.py
the discord url for the welcome invite needs to be suppliedvariables.js
make sure to configure the discord section to beENABLED
, the botTOKEN
and theEVENT_CHANNELS
environment.py
the IP_TO_SUBDOMAIN should be untouched, if running in SDK mode, make sure to map REQUEST_IP_TO_HOSTNAME properly