search

kaansoral / adventureland

Adventure Land The Open Source CODE MMORPG
Other
189 stars 60 forks source link

Fix bug with Giveaways #125

Closed FreezePhoenix closed 5 months ago

FreezePhoenix commented 6 months ago

This fixes a bug with giveaways. Giveaways would previously list all of the participants of a giveaway in the mail, but at some point a breaking change occurred, and instead it lists [object Object] multiple times.

Example of bugged behavior: image

FreezePhoenix commented 6 months ago

grumble

FreezePhoenix commented 6 months ago

Fixed another bug with giveaways: If a player (who won the giveaway) was not on the server when the giveaway ended, or their inventory was full, then the server would push { name: undefined } into the list of players that could win the giveaway. This would send the item into the abyss, as it would error while the server would try to mail the item, preventing it from being recovered.