search

kaansoral / adventureland

Adventure Land The Open Source CODE MMORPG
Other
199 stars 62 forks source link

When Fishing or Mining something that uses `open` keep the phrase #84

Closed thmsndk closed 8 months ago

thmsndk commented 10 months ago

When you fish up lglitch instead of saying you got the item by fishing, it would say you just "Received" it. this patch preserves the context for Fishing and Mining in the phrase.

image

kaansoral commented 9 months ago

I think it should just say "Fished an Amulet of Intelligence"

thmsndk commented 9 months ago

I opted for keeping the item you opened in the message, in case you could fish other things up that would auto open (I know we can't now) but let's say we add clams that can contain clam meat or pearls, or something like that :P

But I can remove the additional message info if you feel that is better.

FreezePhoenix commented 9 months ago

For convenience, clams or other things probably wouldn't auto-exchange on fishing them, you'd talk to the fisherman

thmsndk commented 8 months ago

@kaansoral It should now say

"Fished an Amulet of Intelligence"

Feel free to merge it :)

FreezePhoenix commented 8 months ago

+1, this also fixes a bug with PVP marked exchanges. Previously, if the item being exchanged was marked with PVP, and there was an auto-open drop table entry (like basicelixir in G.drops.seashell) then the resulting item from that opened drop table would not have the PVP flag.