search

kaazing / gateway

Kaazing Gateway
Apache License 2.0
141 stars 84 forks source link

Fix the diagnostic message for unexpected exception to include session details #836

Closed stanculescu closed 7 years ago

stanculescu commented 7 years ago

Added unit test in transport/wsn module.

stanculescu commented 7 years ago

Hello @cmebarrow , this is my first attempt to fix issue #685. Can you please review ? I don't have the rights yet to add you as assignee of the PR.

sbadugu commented 7 years ago

@stanculescu I added you to the list, you should now have permissions to add assignees.

cmebarrow commented 7 years ago

Travis build failed in mina.netty:

Failed tests: 
  DefaultNioSocketChannelIoSessionConfigTest.testSetAllSendBufferSize:122 expected:<2048> but was:<2304>
  DefaultNioSocketChannelIoSessionConfigTest.testSetAllTrafficClass:161 expected:<2> but was:<0>

This failure is probably not caused by the changes in this PR, but there is no filed issue for it. Restarted the build to see if it happens again.

Anisotrop commented 7 years ago

The two tests seem to fail on Ubuntu even on develop branch. They were skipped by default this is why Travis builds passed until now. I have created a PR that ignores those tests and links to a newly created issue.

cmebarrow commented 7 years ago

@stanculescu Please merge @Anisotrop 's PR (it will go into this PR) so I can merge this one once the build succeeds.