search

kaazing / gateway

Kaazing Gateway
Apache License 2.0
141 stars 84 forks source link

(issue#912, management) Fixed a memory leak by altering CollectOnlyMa… #841

Closed cmebarrow closed 7 years ago

cmebarrow commented 7 years ago

…nagementSessionStrategy.soSessionClosed to call doSessionClosedListeners on the sessionBean.

This should hopefully address the memory leak noted in ticket 912: the gateway is accumulating SessionMXBeanImpl instances.

danibusu commented 7 years ago

The PR looks good and seems to fix the problem. I didn't merge because I thought of adding an integration test.

cmebarrow commented 7 years ago

@danibusu Any ideas for how to do the integration test? I thought it might be possible to do one by using a test service so it can examine the MX bean on the session. I am not sure it's possible though. The unit test does confirm the code change.

cmebarrow commented 7 years ago

@dpwspoon Please merge this once the build completes. @danibusu has reviewed the changes and did an IT which I have added (JmxSessionIT).

cmebarrow commented 7 years ago

Build failed twice in http.proxy service (ProxyServiceTest), filed as https://github.com/kaazing/gateway/issues/846

cmebarrow commented 7 years ago

@danibusu @dpwspoon Please merge this now build has passed.