update gateway login challenge behavior

kaazing / gateway

Kaazing Gateway

Apache License 2.0

141 stars 84 forks source link

update gateway login challenge behavior #871

Closed danibusu closed 7 years ago

danibusu commented 7 years ago

update login modules to throw exception instead of returning false
add integration tests for login behavior
update xsd and code so challenge scheme is not mandatory
update unit tests

dpwspoon commented 7 years ago

@danibusu Thanks, looks very good to me with minor feedback. @NicoletaOita, does this cover all the tests cases you were thinking of (CC @sbadugu)?

NicoletaOita commented 7 years ago

@dpwspoon Yes, the tests that @danibusu added cover my test cases. It would be useful however to have some gateway requirements related to these login modules. I could check again if there are any corner cases after we have documentation.

danibusu commented 7 years ago

@dpwspoon I updated the code of the login modules based on your comments. I'm still working on the integration test observations.

dpwspoon commented 7 years ago

@DoruM Are you going to review this?