search

kaazing / gateway

Kaazing Gateway
Apache License 2.0
141 stars 84 forks source link

Avoid a ClassCastException when channel is NioChildDatagramChannel. #885

Closed StCostea closed 7 years ago

StCostea commented 7 years ago

Adding a dummy ReadDispatcher specific for NioChildDatagramChannel. Its dispatch() method is never called.

dpwspoon commented 7 years ago

@jitsni will you review this please

StCostea commented 7 years ago

@jitsni Did you have a chance to check this one ? Thanks.

dpwspoon commented 7 years ago

@jitsni please review once @StCostea has updated the code

jitsni commented 7 years ago

Also, it is related to https://github.com/kaazing/gateway/issues/818

jitsni commented 7 years ago

The fix avoid the ClassCastException, but I wonder if it masks any actual problem

jitsni commented 7 years ago

Closing this one as a new PR will address the issue.