search

kaazing / gateway

Kaazing Gateway
Apache License 2.0
141 stars 84 forks source link

Log rule bug #892

Closed StCostea closed 7 years ago

cmebarrow commented 7 years ago

@StCostea Once this is merged are you planning to make similar changes to Enterprise Gateway to use the new rule? That would be highly desirable I would think.

StCostea commented 7 years ago

@cmebarrow I started to check EE (but did not finish) and did not find any situation where this is required. But yes, we do need to update EE also. After the merge for this PR I will do it.

As for the comments, sorry about that, the previous PR that I closed had the issue connected. I will connect this one also.

StCostea commented 7 years ago

Sorry, it seems it was the wrong issue. :(

cmebarrow commented 7 years ago

@StCostea Looks good. Please resolve the build failure then I or @dpwspoon can merge. Build failure was [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.11:check (validate) on project test.util: Failed during checkstyle execution: There are 4 checkstyle errors. -

StCostea commented 7 years ago

I don't see the error in Travis. I will try to rebuild locally.