search

kaazing / http2-cache.js

2 stars 11 forks source link

implement persistent debugLevel #43

Open hthetiot opened 7 years ago

hthetiot commented 7 years ago

Implement persistent debugLevel via setDebugLevel second argument persist. Use localStorage when available or private in memory as fallback.

XMLHttpRequest.configuration.setDebugLevel('debug', true);

dpwspoon commented 7 years ago

What's the use case for this and do we need this?

dpwspoon commented 7 years ago

I think we should formalize on the README how we want logging to work. It is unclear to me how we want it to work long-term and with what API.

If the API changes on this PR are not what we want long term then we should indicate that it is private/subject to change, perhaps by making it not enumerable (maybe it already is, or adding _, or etc/thoughts?).