search

kab-dot / pe

0 stars 0 forks source link

Cannot add names with slashes #2

Open kab-dot opened 2 months ago

kab-dot commented 2 months ago

Screenshot 2024-04-19 at 4.16.53 PM.png

Unable to add the name Alice s/o ALison Kapoor which may the case for many names with s/o or d/o

soc-pe-bot commented 2 months ago

Team's Response

Thank you for raising this point.

The motivation behind this issue is valid. As per the UG, it is specified that such special characters is not supported since the name must be alphanumeric. We should point out that behavior is as specified by the UG, hence it is not a functionality bug, but a feature flaw. Additionally, the software throws a suitable error message. Given the amount of work that has been done already, we believe that this issue should be considered as NotInScope, as per CS2103/T guidelines:

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Issue with Handling Abbreviations “s/o”, “d/o” and Hyphens in Name Field

Screenshot 2024-04-19 at 4.16.50 PM.png

Screenshot 2024-04-19 at 4.17.59 PM.png

Description: I’ve observed that the system currently disallows the use of the abbreviations “s/o” (son of), “d/o” (daughter of) and “-“ (hyphens), commonly used as part of legal names. This issue may prevent users from entering their full legal names as they appear on their official documents.

Steps to Reproduce:

  1. Navigate to enter command box.
  2. Enter a name including the abbreviations “s/o” or “d/o” (e.g., John Doe s/o Richard Doe).
  3. Hit enter and attempt to add the user.

Expected Behavior: The system should accept legal names containing “s/o”, “d/o” and “-“ as these are valid components of names in many legal documents.

Actual Behavior: The system displays an error message indicating that these abbreviations and hyphens are not allowed, and the user cannot be added with these abbreviations and hyphens included in the name field.

Suggested Improvement: It would be beneficial to adjust the validation rules to allow for the inclusion of “s/o”, “d/o” and “-“ in the name field to accommodate all users' needs and reflect the diversity of name formats. This change would ensure that the system is more inclusive and better serves a global user base.

[original: nus-cs2103-AY2324S2/pe-interim#1216] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for raising this point.

The motivation behind this issue is valid. As per the UG, it is specified that such special characters is not supported since the name must be alphanumeric. We should point out that behavior is as specified by the UG, hence it is not a functionality bug, but a feature flaw. Additionally, the software throws a suitable error message.

image.png

Given the amount of work that has been done already, we believe that this issue should be considered as NotInScope, as per CS2103/T guidelines:

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]