search

kab-dot / pe

0 stars 0 forks source link

No error message thrown #5

Open kab-dot opened 2 months ago

kab-dot commented 2 months ago

Screenshot 2024-04-19 at 4.28.15 PM.png typing pair 6 5 5 5 5 pairs 6 on befriendee with 5 on volunteer but there should be an error message thrown as the command format is incorrect

nus-pe-script commented 2 months ago

Team's Response

Both issues state an issue with additional parameters for the pair and unpair commands being ignored instead of throwing an error. This refers to the same parser issue and fixing one with fix the other.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect command format but no error message thrown

Screenshot 2024-04-19 at 4.29.45 PM.png same problem with unpair, typing unpair 6 5 5 5 5 unpairs 6 with 5 but it has an incorrect command format

[original: nus-cs2103-AY2324S2/pe-interim#2575] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Good catch!

Currently, the pair/unpair command parser ignores extraneous parameters outside of the two provided indexes. We believe both are duplicates, as they are the exact same buggy behavior caused by the same defect. The parsers call the same method logic and hence fixing one constitutes fixing the other.

We will accept this as not in scope as well since this the absence of this enhanced parsing support proposed does not hinder or limit users to accomplish pairing or unpairing.

We propose the severity to be Low as the user is fully aware of the pair and unpair command format, thus this lack of the suggested feature does not inconvenience the user at all.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** However, even if a wrong input is given, I do believe an error message should be thrown as it could confuse possible users if they could put in multiple values even after reading the UG.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]