kab-dot / pe

0 stars 0 forks source link

Incorrect command format but no error message thrown #6

Open kab-dot opened 2 months ago

kab-dot commented 2 months ago

Screenshot 2024-04-19 at 4.29.45 PM.png same problem with unpair, typing unpair 6 5 5 5 5 unpairs 6 with 5 but it has an incorrect command format

nus-pe-script commented 2 months ago

Team's Response

Good catch!

Currently, the pair/unpair command parser ignores extraneous parameters outside of the two provided indexes. We believe both are duplicates, as they are the exact same buggy behavior caused by the same defect. The parsers call the same method logic and hence fixing one constitutes fixing the other.

We will accept this as not in scope as well since this the absence of this enhanced parsing support proposed does not hinder or limit users to accomplish pairing or unpairing.

We propose the severity to be Low as the user is fully aware of the pair and unpair command format, thus this lack of the suggested feature does not inconvenience the user at all.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Hmm, I still think this could potentially cause an issue as the input is incorrect but still gives a valid output, possibly confusing users.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]