kabachuha / MinecraftEcologyMod

Mod, that adds pollution and climate changing system to Minecraft
http://minecraft.curseforge.com/projects/ecology-mod
MIT License
19 stars 10 forks source link

Various fixes and performance improvements #27

Closed pupnewfster closed 6 years ago

pupnewfster commented 6 years ago
kabachuha commented 6 years ago

Thank you for this hard work. I've viewed your PR and I'm going to merge it soon, but I think that I should first improve the config versioning system to avoid possible conflicts with new PollutionSources.

pupnewfster commented 6 years ago

One way is you could package the latest version in the jar. And if a pollution source is missing it looks for what value it has in the packaged version.

pupnewfster commented 6 years ago

Do you have any idea when you will come up with a better config versioning system or should I revert the spelling corrections to the config so that this can be accepted?

kabachuha commented 6 years ago

I think I would implement forge-like JSON versionising system(file on the GitHub with a map like [supported versions]-[URL to config file]).