search

kabanero-io / collections

Kabanero Collections - This repo will be archived soon.
https://kabanero.io
Apache License 2.0
10 stars 29 forks source link

Stack java-microprofile not working appsody run #64

Closed csantanapr closed 5 years ago

csantanapr commented 5 years ago

Stack java-microprofile not working appsody run

To Reproduce Steps to reproduce the behavior:

  1. Install appsody version 
    appsody version
appsody 0.4.2
  2. Add Collection and set as default 
    appsody repo add kabanero https://github.com/kabanero-io/collections/releases/download/v0.1.0//kabanero-index.yaml

    Check list

    
appsody list

REPO ID VERSION TEMPLATES DESCRIPTION kabanero java-microprofile 0.2.9 default Eclipse MicroProfile on Open Liberty & OpenJ9 using Maven kabanero java-spring-boot2 0.3.6 default, kotlin Spring Boot using OpenJ9 and Maven kabanero nodejs 0.2.5 simple Runtime for Node.js applications kabanero nodejs-express 0.2.5 simple, skaffold Express web framework for Node.js kabanero nodejs-loopback 0.1.3 *scaffold LoopBack 4 API Framework for Node.js

3. Do the init

mkdir java-microprofile-app cd java-microprofile-app/ appsody init java-microprofile

4. run

appsody run

5. See error

**Expected behavior**
appsody run to work

**Actual behaviour**
Error

Running development environment... Running command: docker[pull kabanero/java-microprofile:0.2] Running docker command: docker[run --rm -p 7777:7777 -p 9080:9080 -p 9443:9443 --name java-microprofile-app-dev -v /Users/csantana23/.m2/repository:/mvn/repository -v /Users/csantana23/dev/case/cloudpak/apps/java-microprofile-app/src:/project/user-app/src -v /Users/csantana23/dev/case/cloudpak/apps/java-microprofile-app/pom.xml:/project/user-app/pom.xml -v /Users/csantana23/.appsody/appsody-controller:/appsody/appsody-controller -t --entrypoint /appsody/appsody-controller kabanero/java-microprofile:0.2 --mode=run] [Container] Running Install: ../validate.sh && mvn -Dmaven.repo.local=/mvn/repository install -DskipTests [Container] Installing parent dev.appsody:java-microprofile:0.2.11 [Container] [INFO] Scanning for projects... [Container] [INFO] [Container] [INFO] ------------------------------------------------------------------------ [Container] [INFO] Building java-microprofile 0.2.11 [Container] [INFO] ------------------------------------------------------------------------ [Container] [INFO] [Container] [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-versions) @ java-microprofile --- [Container] [INFO] Skipping Rule Enforcement. [Container] [INFO] [Container] [INFO] --- maven-install-plugin:2.4:install (default-install) @ java-microprofile --- [Container] [INFO] Installing /project/user-app/../pom.xml to /mvn/repository/dev/appsody/java-microprofile/0.2.11/java-microprofile-0.2.11.pom [Container] [INFO] ------------------------------------------------------------------------ [Container] [INFO] BUILD SUCCESS [Container] [INFO] ------------------------------------------------------------------------ [Container] [INFO] Total time: 3.129 s [Container] [INFO] Finished at: 2019-09-05T22:03:50Z [Container] [INFO] Final Memory: 7M/11M [Container] [INFO] ------------------------------------------------------------------------ [Container] Project is missing required parent: [Container] [Container] dev.appsody [Container] java-microprofile [Container] 0.2.11 [Container] [Container] [Error] FATAL error APPSODY_PREP command received an error. The controller is exiting: exit status 1 [Error] Error waiting in 'appsody run' exit status 1

groeges commented 5 years ago

This should now be working. Please try again with the latest release.

csantanapr commented 5 years ago

Hi @groeges

Try again using the lastest release? v0.1.2 ?

groeges commented 5 years ago

Sorry yes, "v0.1.2". So do:

appsody repo add kabanero https://github.com/kabanero-io/collections/releases/download/v0.1.2/kabanero-index.yaml

and try your test scenario again. It should now work.

groeges commented 5 years ago

If you still have an issue then please check the in your pom.xml file. The error is complaining that you didn't have 0.2.11 of java-microprofile. Moving to use v0.1.2 of Kabanero collections will probably cause it to complain that you don't have 0.2.12 of java-microprofile. If it does this then just update the in your pom to be 0.2.12

nastacio commented 5 years ago

Probably closed by https://github.com/appsody/stacks/pull/329

sympatheticmoose commented 5 years ago

@csantanapr can this be closed?

csantanapr commented 5 years ago

I think we still have an issue

The collection stack should point to docker image tag using the 3 fields version x.y.z

The base stack the .appsody config dile points to x.z like 0.2 appsody docker image and this tag is being updated in the daily basis but the x.y.z is inmutable like 0.2.12

Users will continue to have problems as incompatible changes are done to 0.2 for example something that was working a few weeks ago suddenly stops working now.

nastacio commented 5 years ago

As I understand it, bumps to third digit are for patches only, per https://semver.org/

Incompatible changes should be reserved for the first digit only.

sympatheticmoose commented 5 years ago

@nastacio pre 1.0.0 you can do breaking changes in any update

nastacio commented 5 years ago

@sympatheticmoose. If that is the case, I tend to agree with @csantanapr previous comment about referencing x.y.z.

As a compromise when x=0, there is an opportunity to leverage those last 2 digits to allow freedom of development to make sweeping changes (bump the second digit ) and provide some stability for early adopters (bump the third digit for patches) .

kylegc commented 5 years ago

FYI there's a related discussion and open issue for this in the Appsody project: https://github.com/appsody/stacks/issues/315

marikaj123 commented 5 years ago

@ianpartridge - What are the next required steps before it can get closed?

kilnerm commented 5 years ago

@marikaj123, We need confirmation the issue has been resolved. Our testing shows no further problems but we would like confirmation from @csantanapr.

csantanapr commented 5 years ago

Was this fix in the latest released v0.2.0 ?

csantanapr commented 5 years ago

Oh duh I see the tag was added for release-0.2

csantanapr commented 5 years ago

I will test it out

marikaj123 commented 5 years ago

@csantanapr - After you verify, please close the issue.

csantanapr commented 5 years ago

Tried released 0.2.0-rc1

the pom.xml contains the correct info now, and no errors

    <parent><!--required parent POM-->
        <groupId>dev.appsody</groupId>
        <artifactId>java-microprofile</artifactId>
        <version>[0.2, 0.3)</version>
        <relativePath/>
    </parent>