search

kabanero-io / docs

Kabanero documentation. This repo will be archived soon.
https://kabanero.io/docs/
Apache License 2.0
7 stars 30 forks source link

Guide on how to curate pipelines #333

Closed kvijai82 closed 4 years ago

kvijai82 commented 4 years ago

Will provide content here shortly.

kvijai82 commented 4 years ago

@jantley-ibm Have a draft written up here: https://github.com/kabanero-io/kabanero-pipelines/blob/doc-curate/docs/Curation.md

Please review and let me know if you need more info. Thanks!

jantley-ibm commented 4 years ago

@chirp1 could you review this new guide, keeping an eye to the terminology guidance in #267 ?

jantley-ibm commented 4 years ago

@t-koman could you review this guide?

t-koman commented 4 years ago

@jantley-ibm Yes I can review it...... Ming also assigned me https://github.ibm.com/IBMCloudPak4Apps/icpa-docs-kc/issues/327 -- which I see is closed....

t-koman commented 4 years ago

@jantley-ibm Jeff, is the process to create a branch, make edits, then share those edits with the author, who will perform the pull request? I do not want to integrate any of my suggested changes unless the author agrees...... Is this right way to process the reviews ? thanks

jantley-ibm commented 4 years ago

@t-koman create a branch, make your changes, commit, push, create a PR, assign the author as a reviewer of the PR. Author reviews, you can make edits and push to the same PR, author approves and merges when all done.

t-koman commented 4 years ago

@jantley-ibm Thanks for the instrutions.... it looks like after I create the PR, assign the author as reviewer of the PR....We can go back and forth with the PR..... until the author approves it, then the author does the merge .... correct ?

bschrammIBM commented 4 years ago

@kvijai82 @t-koman Please confirm that all pipeline instructions are correct for the procedure for creating the PV. We previously documented it as optional, is this still correct?

bschrammIBM commented 4 years ago

epic is https://github.com/kabanero-io/kabanero-pipelines/issues/178

jantley-ibm commented 4 years ago

completed, closing