search

kabanero-io / kabanero-command-line-services

This repo will be archived soon.
Apache License 2.0
3 stars 7 forks source link

Lump defect to fix review comments after master merge #110

Closed davco01a closed 4 years ago

davco01a commented 4 years ago

From a serviceability perspective, you might want to think about detecting the case where there are no repositories separately. And then this catch block can be for unexpected errors. I'm sure this works fine for now as it is.

davco01a commented 4 years ago

You should not have to set these fields (lines 415-419). The createOwnerReference() method should be doing that. If it's not working that way you can write a defect to the operator-java-bindings project.

e.g.

KabaneroApi kApi = new KabaneroApi(apiClient); V1OwnerReference owner = kApi.createOwnerReference(kab); owner.setKind(kab.getKind());

davco01a commented 4 years ago

for deactivate:

Do you need to print an error message if they supplied a version, but that version was not currently in the Stack CR spec?

davco01a commented 4 years ago

for liveness:

should this initially be false ?

public static boolean readGitSuccess=true; . in StackUtils

davco01a commented 4 years ago

all fixed in latest