kabanero-io / kabanero-command-line-services

This repo will be archived soon.
Apache License 2.0
3 stars 7 forks source link

Allow CLI service to continue working even without container registry secret #180

Closed davco01a closed 4 years ago

davco01a commented 4 years ago

Allow CLI service to continue working even without container registry secret

Just display unknown for digest check if no container registry secret has been setup

jgawor commented 4 years ago

@davco01a what happens if my registry does not require authentication?

davco01a commented 4 years ago

Good question, I'll look into that variation too

mtamboli commented 4 years ago

@davco01a what happens if my registry does not require authentication?

Yes, that is the discussion I am having with @davco01a if we really need registry secret to check digests when using public docker hub for stack images.

davco01a commented 4 years ago

Yes, coded to work with and without credentials (secret) now, testing now

davco01a commented 4 years ago

merged: https://github.com/kabanero-io/kabanero-command-line-services/pull/182