Make adding tools to UI more generic

kabanero-io / kabanero-landing

A console application for managing your Kabanero instances. This repo will be archived soon.

Apache License 2.0

4 stars 6 forks source link

Make adding tools to UI more generic #174

Closed kSee04 closed 4 years ago

kSee04 commented 4 years ago

What was fixed? (Issue # or description of fix)

Closes #163

This PR updates how instance.js loads the tools to be more generic. Instead of checking for three whitelisted tools to display, the setToolData function reads in newly added data from tools.json and inserts it into a copy of the newly added html template in instance.html. This PR also edits the grid structure in instance.html so the tool tiles don't have to be indented. KabaneroTool java class also needs new instance variables.

claassistantio commented 4 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: kSee04
:x: Kevin See

Kevin See seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

kSee04 commented 4 years ago

Closing to open with new branch