search

kabanero-io / kabanero-landing

A console application for managing your Kabanero instances. This repo will be archived soon.
Apache License 2.0
4 stars 6 forks source link

Suppress warning messages on governance for invalid stacks #241

Closed dacleyra closed 4 years ago

dacleyra commented 4 years ago

Describe the bug

Originally from @mtamboli https://github.com/kabanero-io/kabanero-operator/issues/700

After enabling OAuth for landing page, I see that governance policy is displayed. But it is showing below warning about active stacks which does not relevant to me and taking too much attention of the user. Talked to @dacleyra and he thinks that operator might be able suppress them.

image

Probably need to check active/inactive before performing digest check. An inactive Stack does not have a Status with asset digests.

Expected behavior

Actual behavior

Steps to reproduce the bug

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. See error

Environment where the bug occurred

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

alohr51 commented 4 years ago

@stephenkinder @mdenby @davco01a Any thoughts on whether to show or not show the digest warning when a stack is inactive.

My thoughts:

Keep showing the warning on inactive status - I think its nice to know there will be a warning if you do decide to activate the stack.

Do not show the warning on inactive status - Will not distract the user from thinking there is a problem, cleaner UI, but will show up the second they activate the stack which may be a surprise. This also means they won't know there is a digest issue until they already activated the stack.

mtamboli commented 4 years ago

@stephenkinder @mdenby @davco01a Any thoughts on whether to show or not show the digest warning when a stack is inactive.

My thoughts:

Keep showing the warning on inactive status - I think its nice to know there will be a warning if you do decide to activate the stack.

Do not show the warning on inactive status - Will not distract the user from thinking there is a problem, cleaner UI, but will show up the second they activate the stack which may be a surprise. This also means they won't know there is a digest issue until they already activated the stack.

@alohr51 Why would the warning be there when you activate? warning was not there when stacks were active. Warning happening when the stack is deactivated.

davco01a commented 4 years ago

The digest metadata is unavailable in the Stack CR when it’s inactive

mdenby commented 4 years ago

If the stack is in use, then show the warning. But if it's not being used--for either/or builds and deploys--don't show it.

stephenkinder commented 4 years ago

@alohr51 @davco01a Since the Stack CR holds the digest at the time of activation, the digest value is undefined if it is inactive. When you active the stack, the digest will be set -- so no error will result when the stack is reactivated, the "digest at activation" is reset to the new value.

davco01a commented 4 years ago

+1 @stephenkinder