search

kabbi / zigbee2mqtt-adapter

zigbee2mqtt adapter for WebThings gateway
Mozilla Public License 2.0
21 stars 13 forks source link

Integrate zigbee2mqtt #12

Closed flatsiedatsie closed 3 years ago

flatsiedatsie commented 5 years ago

The latest version of my fork runs the zigbee2mqtt project from a sub-directory of the add-on. Mozilla doesn't want to accept add-ons anymore that require the installation of things onto the system.

Perhaps something like this could be incorporated into this version?

See also: https://github.com/Koenkk/zigbee2mqtt/issues/1849

nobodypb commented 4 years ago

Are you sure that the requirement of zigbee2mqtt is the problem? It seems to me, that simply the manifest.json is missing, which is required by mozilla. #15 should fix that then. According to mozillas guidelines addons must not install system-wide dependencies. Relying on them shouldn't be a problem. Since we're using MQTT it's also not really required to have zigbee2mqtt on the gateway system. I'd prefer this flexibility over including it into this adapter. However it seems like the fundamental issue is, that this project needs an active maintainer to be of value for the regular users. @kabbi would you hand it over to @flatsiedatsie, since he is somewhat active here?

kabbi commented 4 years ago

Yeah, sorry that I don't have enough time to maintain this project. That, and also I moved to Home Assistant with seamless zigbee2mqtt integration. I have no problem giving this project to anyone willing to maintain it. @flatsiedatsie do you want to be a maintainer?

nobodypb commented 4 years ago

No problem, I know that very well. Life only allows a limit number of projects at the same time. However it'd be quite sad, if this project would be abandoned. I think there's a lot of potential in both zigbee2mqtt and webthings gateway. So bringing them together is awesome and I wonder why there's no bigger interest in that. I also use Home Assistant, but think Mozillas Webthings Gateway has it's use too. Especially since it's allows me to write JS and I'm a former web dev :wink: It's perfect as nice minimal UI, whilst thanks to zigbee2mqtt I'm also able to use Home Assistant on the same zigbee network.

Since I have very limited time too, I wouldn't want to maintain this myself. (People likely wouldn't be any happier with me as maintainer) But I'm willing to help anyone who takes over this task. For now I forked your repo, merged the open PRs and fixed (hopefully) all issues resulting from that. For anyone interested, check it out here: https://github.com/nobodypb/zigbee2mqtt-adapter/tree/0.2.7

flatsiedatsie commented 4 years ago

@kabbi by all means make me a shared maintainer. It's actually something I've been wanting to look into again.

kabbi commented 4 years ago

@flatsiedatsie You're welcome!

flatsiedatsie commented 3 years ago

Zigbee2MQTT is now nicely integrated - it is installed and (optionally) updated on demand by the addon.

The addon will now be an 'official' addon for the WebThings Gateway, giving users a second way to attempt to connect Zigbee devices.

anvo commented 3 years ago

Since we're using MQTT it's also not really required to have zigbee2mqtt on the gateway system. I'd prefer this flexibility over including it into this adapter.

Unfortunately, I am supporting this. I had zigbee2mqtt up and running before I found my way to WebThings. Including zigbee2mqtt as part of this adapter does not add any benefit (for me!) but has an huge impact on the maintainability of the project (+ the code).

Plus, when using the official webthings gateway docker images, the logs throws errors as zigbee2MQTT fails to install: zigbee2mqtt-error-log.txt

flatsiedatsie commented 3 years ago

Yeah I was wondering about this. I'll make it optional.

has an huge impact on the maintainability of the project (+ the code).

The Zigbee2MQTT code is not part of the addon itself. On firstboot it downloads an installs the latest version of zigbee2MQTT. It can then keep this download up-to-date, but that is already optional, and can be disabled in the addon settings.