Blazor related changes

[friendlyanon]

I'll admit I have no idea what I have to do to the csproj to accept solution wide defines, so I did this.
You can check out my ZoraGen Blazor project to maybe get a better idea what I tried to achieve here.

The reason why the BLAZOR_NO_NOTIFY_PROPERTY_CHANGED define needed to be introduced is that System.ComponentModel.INotifyPropertyChanged does not work with Blazor.

You most definitely should make changes to this PR if you know how to achieve perfectly what I tried to do here.

[codecov[bot]]

Codecov Report

Merging #10 into master will increase coverage by 0.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage      94%   94.19%   +0.19%     
==========================================
  Files          13       13              
  Lines        1051     1051              
  Branches       78       78              
==========================================
+ Hits          988      990       +2     
  Misses         53       53              
+ Partials       10        8       -2

Impacted Files	Coverage Δ
src/Secret.cs	96.87% <ø> (ø)	:arrow_up:
src/GameInfo.cs	94.61% <ø> (ø)	:arrow_up:
src/JapaneseEncoding.cs	85.13% <0%> (+1.35%)	:arrow_up:
src/USEncoding.cs	90.76% <0%> (+1.53%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b74fdc...b83197f. Read the comment docs.

[codecov[bot]]

Codecov Report

Merging #10 into master will increase coverage by 0.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage      94%   94.19%   +0.19%     
==========================================
  Files          13       13              
  Lines        1051     1051              
  Branches       78       78              
==========================================
+ Hits          988      990       +2     
  Misses         53       53              
+ Partials       10        8       -2

Impacted Files	Coverage Δ
src/Secret.cs	96.87% <ø> (ø)	:arrow_up:
src/GameInfo.cs	94.61% <ø> (ø)	:arrow_up:
src/JapaneseEncoding.cs	85.13% <0%> (+1.35%)	:arrow_up:
src/USEncoding.cs	90.76% <0%> (+1.53%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b74fdc...996fd48. Read the comment docs.

[kabili207]

I think I have an idea how to do this with minimal issues. I'll play around with this over the weekend.

[codecov-io]

Codecov Report

Merging #10 into master will increase coverage by 0.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage      94%   94.19%   +0.19%     
==========================================
  Files          13       13              
  Lines        1051     1051              
  Branches       78       78              
==========================================
+ Hits          988      990       +2     
  Misses         53       53              
+ Partials       10        8       -2

Impacted Files	Coverage Δ
src/Secret.cs	96.87% <ø> (ø)	:arrow_up:
src/GameInfo.cs	94.61% <ø> (ø)	:arrow_up:
src/JapaneseEncoding.cs	85.13% <0%> (+1.35%)	:arrow_up:
src/USEncoding.cs	90.76% <0%> (+1.53%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b74fdc...996fd48. Read the comment docs.

[codecov-io]

Codecov Report

Merging #10 into master will increase coverage by 0.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage      94%   94.19%   +0.19%     
==========================================
  Files          13       13              
  Lines        1051     1051              
  Branches       78       78              
==========================================
+ Hits          988      990       +2     
  Misses         53       53              
+ Partials       10        8       -2

Impacted Files	Coverage Δ
src/Secret.cs	96.87% <ø> (ø)	:arrow_up:
src/GameInfo.cs	94.61% <ø> (ø)	:arrow_up:
src/JapaneseEncoding.cs	85.13% <0%> (+1.35%)	:arrow_up:
src/USEncoding.cs	90.76% <0%> (+1.53%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b74fdc...996fd48. Read the comment docs.

[kabili207]

I've modified your changes in three ways.

1. The .csproj file has been largely reverted to it original form.
2. I've renamed BLAZOR_NO_NOTIFY_PROPERTY_CHANGED to just simply BLAZOR. It's more concise, and you were using it to disable the [Serializable] attribute as well, which isn't related to NotifyPropertyChanged.
3. I've added an include directive to ZoraSharp.csproj that will attempt to load the file Extra.targets. This file can contain anything you might find in a normal .csproj and will override anything that came before it. This file must be located in the same directory as the .sln file. I've created a pull request (friendlyanon/zoragen-blazor#1) that creates this file with the BLAZOR define.

Let me know if everything works on your end. If it's all good, I'll merge it all in.

[friendlyanon]

All good here, I'll submodule this repo once you merged.