search

kabili207 / zora-sharp

A decoder for the password system used in the Legend of Zelda Oracle of Ages and Oracle of Seasons games.
GNU Lesser General Public License v3.0
48 stars 22 forks source link

Code cleanups #13

Closed carys-the-weed-cloud closed 5 years ago

carys-the-weed-cloud commented 5 years ago

Went through with code analysis.

codecov[bot] commented 5 years ago

Codecov Report

Merging #13 into master will decrease coverage by 0.1%. The diff coverage is 99.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   96.31%   96.21%   -0.11%     
==========================================
  Files          15       15              
  Lines         977      977              
  Branches       73      106      +33     
==========================================
- Hits          941      940       -1     
  Misses         28       28              
- Partials        8        9       +1
Impacted Files Coverage Δ
src/GameInfoJsonConverter.cs 85% <ø> (ø) :arrow_up:
src/USEncoding.cs 100% <ø> (ø) :arrow_up:
src/ChildBehaviorHelper.cs 100% <ø> (ø) :arrow_up:
src/BatteryFileLoader.cs 100% <ø> (ø) :arrow_up:
src/AssemblyDetail.cs 0% <ø> (ø) :arrow_up:
src/BaseEncoding.cs 88% <ø> (ø) :arrow_up:
src/Extensions.cs 100% <ø> (ø) :arrow_up:
src/Attributes.cs 0% <ø> (ø) :arrow_up:
src/JapaneseEncoding.cs 100% <ø> (ø) :arrow_up:
src/Secret.cs 96.87% <100%> (ø) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 268674f...be21d89. Read the comment docs.