kabirbaidhya / angular-ui-block

Angular UI Block Module
MIT License
1 stars 0 forks source link

Cant import in modules for angular 8 #1

Open visa15cs opened 5 years ago

visa15cs commented 5 years ago

i cant import the angularUiBlock module in angular 8.

kabirbaidhya commented 5 years ago

@viveksahu1 I am not sure. I had created this when I was using angular 1.x and I haven't tested it in anything else than that.

Can you post what error did you get? I haven't used angular 8 yet and will need to figure out how to make it compatible -- perhaps needs some work.

visa15cs commented 5 years ago

When I import it, it shows the following error. It will be very thankful if u can please update the documentation for angular 8. Thanks & Regards

On Fri, 25 Oct, 2019, 10:24 PM Kabir Baidhya, notifications@github.com wrote:

@viveksahu1 https://github.com/viveksahu1 I am not sure. I had created this when I was using angular 1.x and I haven't tested it in anything else than that.

Can you post what error did you get?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kabirbaidhya/angular-ui-block/issues/1?email_source=notifications&email_token=AKL7E7D472CQZVTSTVEPLADQQMQFVA5CNFSM4JFFQLXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECI534I#issuecomment-546430449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKL7E7BYLQPQ27GPSGM32FLQQMQFVANCNFSM4JFFQLXA .

kabirbaidhya commented 5 years ago

@viveksahu1 It's still not clear what is the error that you're getting.

Anyway, I think it's incompatible right now. I'll keep the issue open for now -- we'll need to check what it takes to make it compatible for angular > 1.x, = 8.

It might take sometime as it's been a while that I haven't looked in angular projects. If you want it sooner you can take a crack at it meanwhile and see how it goes too :).

visa15cs commented 5 years ago

Thanks alot for your prompt reply. I will wait.

On Fri, 25 Oct, 2019, 11:37 PM Kabir Baidhya, notifications@github.com wrote:

@viveksahu1 https://github.com/viveksahu1 It's still not clear what is the error that you're getting.

Anyway, I think it's incompatible right now. I'll keep the issue open for now -- we'll need to check what it takes to make it compatible for angular

1.x, = 8.

It might take sometime as it's been a while that I haven't looked in angular projects. If you want it sooner you can take a crack at it meanwhile and see how it goes too :).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kabirbaidhya/angular-ui-block/issues/1?email_source=notifications&email_token=AKL7E7BZ2VIHLPDJRP2UKYDQQMYVDA5CNFSM4JFFQLXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECJD32I#issuecomment-546455017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKL7E7AKIZ3WONPURJINOQTQQMYVDANCNFSM4JFFQLXA .