kabisa / kudos-frontend

The frontend for the Kudos-o-Matic! (Mobile / Desktop)
2 stars 0 forks source link

Fix kudo amount input. #140

Closed marcianosr closed 10 months ago

marcianosr commented 10 months ago

What

Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear

Why

Explain why these things are changes. This explanation is for your colleagues and your future self.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

codeclimate[bot] commented 10 months ago

Code Climate has analyzed commit 7ab8e9f8 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 12.8% (0.0% change).

View more on Code Climate.

sandercamp commented 10 months ago

Nice one! Made it work without resorting to hacky solutions I see.

Minor thing I noticed: when a value is selected and I want to change it again the cursor is positioned before the input value. Backspace will still empty the field though.