Put proper language in html lang tag

kabisa / maji

Maji is a framework to build great hybrid mobile apps.

https://www.majimobile.com/

MIT License

18 stars 10 forks source link

Put proper language in html lang tag #155

Open RoelN opened 7 years ago

RoelN commented 7 years ago

In project_template/src/index.html we have hardcoded the language:

<html lang="en">
...

Could this be derived and injected from some settings instead?

pascalw commented 6 years ago

@RoelN I guess we could derive this from the current locale, but I wonder if it matters in any way? From what I can tell it's mainly used by search engines, which given the main target usage for Maji (Cordova apps) is not that important. What do you think?

leonderijke commented 6 years ago

Besides search engines there are a few other uses of the lang attribute:

it will choose the appropriate formats for date and number inputs
it is used by the OS spellchecker to help correct the user's spelling in input fields
it is used by screenreaders to determine the right language, accent and pronunciation

More information: https://www.w3.org/International/questions/qa-lang-why.en

pascalw commented 6 years ago

Ok good to know. Let's implements this based on the current locale.