search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Compare components by their url when applying transitions #184

Closed ruisalgado closed 6 years ago

ruisalgado commented 6 years ago

Routed components will always have a url attribute applied to them by the router. Previously we were comparing based on nodeName, which would prevent transitioning between different component instances of the same kind.

ruisalgado commented 6 years ago

fixes #183

pascalw commented 6 years ago

LGTM 👍 Only thing perhaps is I don't see a test that specifically shows this fixes #183, or am I missing something? Is it easy to add that and do you think that's useful?

ruisalgado commented 6 years ago

added a couple of small tests to verify conditions under which transition should or should not play out.

pascalw commented 6 years ago

Thanks 👍