search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Prevent remounting previousPage when doing page transition #205

Closed ruisalgado closed 6 years ago

ruisalgado commented 6 years ago

fixes #191

ruisalgado commented 6 years ago

would probably be best to get #197 merged before this one

pascalw commented 6 years ago

Looks good to me! Did you verify it indeed prevents remounting?

ruisalgado commented 6 years ago

@pascalw yap it does

pascalw commented 6 years ago

Awesome. I've merged the PR that moves pageTransitionSupport to the library so if you rebase against master we can merge this too 🚀

leonderijke commented 6 years ago

I incorporated this in my current project. It works like a charm! 👍

ruisalgado commented 6 years ago

@leonderijke I incorporated the changes we discussed over slack earlier this week, to prevent multiple versions of the same dependency. Can you give this PR a quick re-review and then :shipit: ?