search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Project template `bin/setup` uses not-yet installed dependency #223

Closed leonderijke closed 6 years ago

leonderijke commented 6 years ago

The default bin/setup script in the project template uses cross-spawn to kick off Yarn. However, this package is often not installed until after running bin/setup, for example when cloning an existing project locally or in CI environments.

pascalw commented 6 years ago

Hm good point. We did this for Windows compatibility.

I think we can do one of the following:

  1. Try to require cross-spawn, if that fails fall back to spawn.
  2. Document that cross-spawn is a global dependency that should be installed first.
  3. Get rid of bin/setup, since it's just an alias for yarn install now.

WDYT?

leonderijke commented 6 years ago

No. 3 sounds good to me. Alternatively, because bin/setup is solely there for backwards compatibility reasons we could also to revert bin/setup back to bash.