search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Non-headless e2e tests fail with recent chromedriver #225

Closed ruisalgado closed 6 years ago

ruisalgado commented 6 years ago

stacktrace: 'org.openqa.selenium.WebDriverException: unknown error: cannot parse capability: chromeOptions\nfrom unknown error: cannot parse args\nfrom unknown error: must be a list\n

This happens because in the nonHeadless nightwatch test env, we set chromeOptions args to null.

Setting the args to [] doesn't work unfortunately, as there's a bug in nightwatch that will cause the default settings to be used, thus reintroducing --headless.

ruisalgado commented 6 years ago

Setting any valid arg will have nightwatch overwrite the default settings as expected. So while the [] bug persists, I'd suggest just setting some (seemingly innocuous) args from the available list. Say... --default looks like a good candidate.

pascalw commented 6 years ago

Is there a Nightwatch issue for this we can track?

leonderijke commented 6 years ago

See nightwatchjs/nightwatch#1729.