search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Disable inclusion of cordova in development mode #228

Closed matthijsgroen closed 6 years ago

matthijsgroen commented 6 years ago

When developing locally, you always get a 404 on cordova.js

This PR disables the inclusion of cordova for development builds.

In the future we could extend this that even in the build process we could omit cordova for building web frontends. (using an env var for instance)

matthijsgroen commented 6 years ago

@leonderijke I don't think that is needed, with the new default I could also remove the env var from yarn start. Cordova is only used in 'build' when a platform is supplied, and in 'run'. So these are the only places it will be 'on' now, and off for all other instances.

leonderijke commented 6 years ago

@matthijsgroen Yeah, you're right. There's no need to expose via bin/maji start.