kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Don't enable Redux devtools support in production #230

Closed pascalw closed 6 years ago

pascalw commented 6 years ago

Enabling Redux devtools support in production does not make sense, and provides insight/hooks into your app that you likely don't want.

leonderijke commented 6 years ago

I'm not sure I agree on this. To me it feels a bit like disabling the mouse right click, like in the old days 😄

If you're worried about exposing the ability to dispatch actions from the devtools etc. you might want to look into restricting the enabled features in production.

matthijsgroen commented 6 years ago

I think it is a sensible default to have it closed at the production run-time. If a project has other needs, it can ofcourse deviate from this default.

pascalw commented 6 years ago

I think disabling it is a sensible default indeed, because yhere's no generic solution to restricting enabled features, so that's not something we can provide out of the box. Can you live with that @leonderijke ? :-)

leonderijke commented 6 years ago

👍