search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Upgrade to Webpack 4 #232

Closed pascalw closed 6 years ago

pascalw commented 6 years ago

Upgrade was quite straightforward.

Performance should be improved quite a bit. The example project compiles in ~ 3.6 seconds vs 7s.

I did have to switch some loaders/plugins to beta releases, so YMMV. Let's try running some projects on this branch before we merge.

I snug in one technically maybe-not-required-but-nice change. I had to use babel-loader 8, which is only compatible with babel 7. babel-preset-env on Babel 7 is much better and doesn't require babel-polyfill, so I removed that.

pascalw commented 6 years ago

@ruisalgado I've updated the PR to only split chunks in prod mode. Have you encountered any other issues or is this good to go?

ruisalgado commented 6 years ago

@pascalw haven't bumped into further issues so I'd be ok merging this

pascalw commented 6 years ago

Sorry for the delay!