search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Bottom navigation #233

Closed ruisalgado closed 6 years ago

ruisalgado commented 6 years ago

TBD whether this should make it to Maji proper. Maybe we need to rethink the example app

pascalw commented 6 years ago

@ruisalgado I'm not sure if we should put this in the default example app. I don't think it's a super common pattern to have this bottom navigation bar, but even besides that I'd say that components like these would better go into https://github.com/kabisa/maji-extras, or at least are made available in such a way that it's easy to import them but not required. WDYT?

ruisalgado commented 6 years ago

@pascalw yeah as I mentioned in the description I also have my doubts. With that said @RoelN has some interesting ideas about setting up a more complete example app. I guess that could live in a separate repo with the more generic components extracted to maji-extras, and leaving the project_template here lean.

I'll move this elsewhere and close the PR soon.

ruisalgado commented 6 years ago

continuing this in a local fork and then sorting out with @RoelN a more appropriate place for it.