Closed ariejan closed 5 years ago
@ariejan can you fix the linting issues as well? Thanks! 👍
Ok, this is interesting. CI is now failing, because we run Prettier on all JS files in the project including the project template. However, the Prettier version used in a new generated project is slightly newer so these different Prettier versions basically disagree :-)
To fix that, I'm excluding the project template from Prettier here.
Something else 🐟 y is going on. There's a duplicate dependency on Prettier which causes weird behavior. Depending on install order, or something else semi random, you might get a different Prettier version. Great! I'll fix this in a separate PR.
https://github.com/kabisa/maji/issues/240 created to fix this.
@ariejan with #240 fixed this change is no longer needed. The code was already correctly formatted for the version of Prettier that was supposed to be used, but you were seeing this failure because the wrong version of Prettier got used.
How to reproduce
yarn create maji-app
bin/maji test
What happens?
What did you expect to happen instead?
This PR updates
WelcomePage.js
for stylelint compliance. This makes a newly generated project pass all tests out of the box.